Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occ enabled cfg #398

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Occ enabled cfg #398

merged 2 commits into from
Jan 18, 2024

Conversation

udpatil
Copy link
Contributor

@udpatil udpatil commented Jan 18, 2024

Describe your changes and provide context

This adds occ-enabled as a config for baseapp to control whether to execute transactions with OCC parallelism.

Testing performed to validate your change

Tested on sei-chain

@udpatil udpatil requested a review from stevenlanders January 18, 2024 16:33
@udpatil udpatil changed the base branch from main to occ-main January 18, 2024 16:34
@udpatil udpatil requested a review from philipsu522 January 18, 2024 16:34
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f49573b) 55.60% compared to head (a8d1b3a) 55.60%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           occ-main     #398   +/-   ##
=========================================
  Coverage     55.60%   55.60%           
=========================================
  Files           629      629           
  Lines         53499    53510   +11     
=========================================
+ Hits          29749    29756    +7     
- Misses        21641    21644    +3     
- Partials       2109     2110    +1     
Files Coverage Δ
baseapp/baseapp.go 73.11% <100.00%> (+0.07%) ⬆️
server/config/toml.go 17.85% <ø> (ø)
server/config/config.go 34.09% <50.00%> (+0.18%) ⬆️
simapp/simd/cmd/root.go 69.38% <0.00%> (-0.29%) ⬇️
baseapp/options.go 53.45% <66.66%> (+0.51%) ⬆️

@stevenlanders
Copy link
Contributor

Does setting to false work? (does it see that as an explicit override to false or does the default of true win because false is a default bool value and looks unset?)

@udpatil
Copy link
Contributor Author

udpatil commented Jan 18, 2024

yeah, it reads a false value specifically if we change the config value to false

@udpatil udpatil merged commit e7a3b65 into occ-main Jan 18, 2024
15 checks passed
@udpatil udpatil deleted the occ-enabled-cfg branch January 18, 2024 21:43
udpatil added a commit that referenced this pull request Jan 18, 2024
## Describe your changes and provide context
This adds `occ-enabled` as a config for baseapp to control whether to
execute transactions with OCC parallelism.

## Testing performed to validate your change
Tested on sei-chain
udpatil added a commit that referenced this pull request Jan 25, 2024
## Describe your changes and provide context
This adds `occ-enabled` as a config for baseapp to control whether to
execute transactions with OCC parallelism.

## Testing performed to validate your change
Tested on sei-chain
udpatil added a commit that referenced this pull request Jan 31, 2024
## Describe your changes and provide context
This adds `occ-enabled` as a config for baseapp to control whether to
execute transactions with OCC parallelism.

## Testing performed to validate your change
Tested on sei-chain
codchen pushed a commit that referenced this pull request Feb 6, 2024
## Describe your changes and provide context
This adds `occ-enabled` as a config for baseapp to control whether to
execute transactions with OCC parallelism.

## Testing performed to validate your change
Tested on sei-chain
udpatil added a commit that referenced this pull request Feb 27, 2024
## Describe your changes and provide context
This adds `occ-enabled` as a config for baseapp to control whether to
execute transactions with OCC parallelism.

## Testing performed to validate your change
Tested on sei-chain
udpatil added a commit that referenced this pull request Mar 1, 2024
## Describe your changes and provide context
This adds `occ-enabled` as a config for baseapp to control whether to
execute transactions with OCC parallelism.

## Testing performed to validate your change
Tested on sei-chain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants